-
-
Notifications
You must be signed in to change notification settings - Fork 66
feat(cli): co-locate css file from usage (+layout.svelte)
#780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 1397e8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
jycouet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR
I think that we should update name & location of packages/create/templates/demo/src/app.css as well to be consistent
Also
cli/packages/addons/prettier/index.ts
Line 56 in 4e5e2f3
| data.tailwindStylesheet ??= './src/app.css'; |
Co-authored-by: jyc.dev <[email protected]>
Co-authored-by: jyc.dev <[email protected]>
.css for tailwindcss file from usage (+layout.svelte)
|
@jycouet I updated the docs and added a second changeset as I didn't manage to combine both features into one good changeset. Let me know what you think |
@benmccann @jycouet following up from the discussion on Discord.
In this PR: