feat: allow to specify options for the service worker in svelte.config.js
#13578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 394d86b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
reviewed
Mar 14, 2025
Comment on lines
+270
to
+272
| // options could be undefined but if it is defined we only validate that | ||
| // it's an object since the type comes from the browser itself | ||
| options: validate(undefined, object({}, true)), |
There was a problem hiding this comment.
we'd still want to error early, no?
There was a problem hiding this comment.
If it's undefined we just don't add the options...if they pass some unknown values it's also fine, this way in case they update the signature we don't need to fix it on our end...or do you mean something else?
There was a problem hiding this comment.
hmm, yeah i guess since we're not using it internally it doesn't really matter — types are sufficient. fair enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no way to pass options for the automatically registered service worker so if you wanted a type module for example you would have to set register to false and manually register it. This PR add the options in the
svelte.config.jsunderkit.serviceWorker.options.I still need to write tests and docs for this but i wanted to put this out there since I can't work on it right now.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits