fix: use wrangler CLI to bundle worker #13640
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13300
This PR uses the Wrangler CLI to bundle the server into a single worker file. Cloudflare has no plans on publishing a public API for this and recommends using the CLI
wrangler deploy --dry-run
command to achieve this.I'm not sure if this is the best way to create a build artefact since we're bundling the worker once and it gets bundled again by Wrangler during deployment (unless the user specifies
--no-bundle
option but this doesn't exist with Git integration). The double bundling lead to a 13kb increase in the final worker size when tested on a SvelteKit default template project. It might be better to wait for the Vite environment API integration and see if we can get the adapter to influence Vite to bundle in the node dependencies.This PR also adds a simple test that checks if an app build is successful and works in the Wrangler dev environment.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits