Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use wrangler CLI to bundle worker #13640

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Mar 25, 2025

fixes #13300

This PR uses the Wrangler CLI to bundle the server into a single worker file. Cloudflare has no plans on publishing a public API for this and recommends using the CLI wrangler deploy --dry-run command to achieve this.

I'm not sure if this is the best way to create a build artefact since we're bundling the worker once and it gets bundled again by Wrangler during deployment (unless the user specifies --no-bundle option but this doesn't exist with Git integration). The double bundling lead to a 13kb increase in the final worker size when tested on a SvelteKit default template project. It might be better to wait for the Vite environment API integration and see if we can get the adapter to influence Vite to bundle in the node dependencies.

This PR also adds a simple test that checks if an app build is successful and works in the Wrangler dev environment.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: 4f757f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@eltigerchino eltigerchino marked this pull request as draft March 26, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[email protected] breaks deployment
1 participant