-
-
Notifications
You must be signed in to change notification settings - Fork 179
svelte.dev/packages #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
svelte.dev/packages #1523
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcb95d9
to
d82d8e2
Compare
67f3cfe
to
b082039
Compare
e7315b1
to
358b438
Compare
358b438
to
bae54bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice 🎉
I can do the 2-3 comments, just let me know.
alias: { | ||
'@inlang/paraglide-js': 'paraglidejs', | ||
'drizzle-orm': 'drizzle' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find alias
used anywhere.
It was to replace the name on the ui card?
Maybe it could be "global" and not just for SV_ADD. (I saw that @inlang/paraglide-js
is in multiple categories)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it's to make it match the adder name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any code in the registry-2
branch where that was ever used, so it looks like we'll have to implement that ourselves if we want it. I do think it makes sense for the sv add-ons row. I don't know that we'd want to rename @inlang/paraglide-js
under "Third party services" because paraglide
is really just referring to the sv add-on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rich-Harris did most of the design and is pretty good at this stuff, so I'd be curious for his opinion on the addition of the Svelte icons and "npx sv add" commands and whether there might be a better way to accomplish this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did what I could, but have to run. I'd definitely appreciate the help with the last comment if you have time and just getting this over the finish line in general. I'm finding less time for Svelte these days, but really wanted to try to help this get launched especially since it'd give us a nice place to highlight sv community add-ons. |
Some thoughts from using it on mobile:
|
Having the card go to the website seems like a good idea |
I don't have too much problem with the number of categories on mobile except that the page is hard to scroll. You can only scroll if you tap between categories and not on a card, which feels wrong to me |
Feels wrong to me too. Also on desktop, when you hover a card and scroll, nothing is happening.
Done with the title only
Done. Yes,
|
Brain dump:
So... idk. This doesn't feel like a curated page of actively-maintained, highly-recommended packages. It feels like a random assortment with a few gems but a lot of dross. I don't really know when I would use this over Google. I think that if we're going to curate, we need to curate much more aggressively. |
Basically ambassadors and maintainers nominate things that are good or not and vote on them to add or remove things. We should definitely have everyone do a pass on this once we've got the rest settled. The content hasn't been thoroughly vetted. The router category hadn't been reviewed at all, so I just cleaned that up a bunch. Reasonable people will disagree on many of the others, but I think they're at least defensible even if not perfect. wuchale looks brand new and not very used, so not surprised it isn't listed here. paraglide even if only infrequently developed is still one of the better libraries out there. For sswr, remote functions only work for sveltekit and non-sveltekit users may still want options. superforms is still being worked on even if a bit behind.; From the superforms repo:
|
This is based off the work from @PuruVJ in https://github.com/sveltejs/svelte.dev/tree/registry-2
I copied over only the svelte.dev/packages homepage without the search functionality or full registry (only the subset of packages we're displaying).
The scripts for updating the registry have also not been copied over. This is probably the main issue as stats such as latest version number, number of stars, number of downloads, etc. will be outdated. I'm not sure how we want to populate those and keep them updated