-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: add a warning when the misuse of reset
in an error:boundary
causes an error to be thrown when flushing the boundary content
#16171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
610b455
to
7490fbe
Compare
🦋 Changeset detectedLatest commit: f686128 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
…s an error to be thrown when flushing the boundary content
… are fired during template effects flush
7490fbe
to
28b0310
Compare
Thank you. The behaviour of boundaries seems just wrong here — an error that occurs during reset should not escape the current boundary; that's deeply unhelpful. Surprised that never surfaced until now. Working on it locally, will push to this PR. Checking that |
Add warning message when situations like #16134 happen.
The user reporting the issue is misusing
reset
by calling it before the problematic template is rendered,reset
"pauses" the error boundary and this allows the error to bubble up.This adds a warning message when this happens instructing the user to fix the problematic app state before calling
reset
or to usereset
when the user clicks a button in the fallback UI.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint