Skip to content

fix: add a warning when the misuse of reset in an error:boundary causes an error to be thrown when flushing the boundary content #16171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

raythurnvoid
Copy link
Contributor

Add warning message when situations like #16134 happen.

The user reporting the issue is misusing reset by calling it before the problematic template is rendered, reset "pauses" the error boundary and this allows the error to bubble up.

This adds a warning message when this happens instructing the user to fix the problematic app state before calling reset or to use reset when the user clicks a button in the fallback UI.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@svelte-docs-bot
Copy link

@raythurnvoid raythurnvoid force-pushed the fix/@sveltejs/svelte/16134 branch from 610b455 to 7490fbe Compare June 15, 2025 19:30
Copy link

changeset-bot bot commented Jun 15, 2025

🦋 Changeset detected

Latest commit: f686128

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16171

@raythurnvoid raythurnvoid force-pushed the fix/@sveltejs/svelte/16134 branch from 7490fbe to 28b0310 Compare June 15, 2025 19:37
@Rich-Harris
Copy link
Member

Thank you. The behaviour of boundaries seems just wrong here — an error that occurs during reset should not escape the current boundary; that's deeply unhelpful. Surprised that never surfaced until now. Working on it locally, will push to this PR.

Checking that reset isn't called during onerror is a good call though, will keep that part of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants