Skip to content

Conversation

yuki0418
Copy link
Contributor

@yuki0418 yuki0418 commented Oct 4, 2025

Closes #16885

Description

Check has_await in consequent and alternate as well.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 4, 2025

🦋 Changeset detected

Latest commit: 1f639d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 4, 2025

Playground

pnpm add https://pkg.pr.new/svelte@16890


if (node.metadata.expression.has_await) {
if (
node.metadata.expression.has_await ||
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, node.metadata.expression.has_await checks {#if await Promise.resolve(true)}.

So it doesn't return true when only consequent or alternate have await operator.

@yuki0418 yuki0418 marked this pull request as ready for review October 4, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot dynamically import and await a Svelte component in SSR
1 participant