Skip to content

feat(rolldown-vite): enable optimization.inlineConst by default #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2025
Merged

feat(rolldown-vite): enable optimization.inlineConst by default #1207

merged 4 commits into from
Sep 9, 2025

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Aug 28, 2025 •
edited
Loading

This is going to help with treeshaking and esm-env.

@dominikg dominikg marked this pull request as ready for review September 8, 2025 08:34
paoloricciuti
paoloricciuti approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@paoloricciuti paoloricciuti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just left a comment but if you feel it's not the case feel free to merge!

@dominikg dominikg merged commit e1ffd09 into main Sep 9, 2025
8 checks passed
@dominikg dominikg deleted the feat/improve-rolldown-build branch September 9, 2025 14:00
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paoloricciuti paoloricciuti paoloricciuti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikg @paoloricciuti