Added net6.0-windows to TFMs. #1019
Closed
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the fact that in .NET 6 S.D.C is Windows only, I decided to make a Windows only target for .NET 6 which removes a few annoying package refs that get placed into my build outputs in my .NET 6 WinForms applications that use Svg. If the application is windows only, I see no need to include the ``osx`` System.Drawing runtime reference either.
AraHaan
commented
Oct 19, 2022
|
@wieslawsoltes - can you have a look at this? I'm traveling... |
|
I might have to rebase this after all this time. |
Thanks, also consider adding .NET 8 (we could skip the 7), net472, net481. update the samples. |
|
I would say that would be the best thing to do as well. |
Closed
|
After the analysis, package like Open-XML-SDK uses SVG-NET and targets and
The package libgdiplus-packaging is actually marked as
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that in .NET 6 S.D.C is Windows only, I decided to make a Windows only target for .NET 6 which removes a few annoying package refs that get placed into my build outputs in my .NET 6 WinForms applications that use Svg. If the application is windows only, I see no need to include the
osxSystem.Drawing runtime reference either.Reference Issue
Contributes to: #939
What does this implement/fix? Explain your changes.
This adds a
net6.0-windowstarget to Svg which allows it to be used in .NET 6 WindowsDesktop applications without annoyingly unneeded dependencies polluting the output directory in them.Any other comments?
None.