Cancellation status messages for registrations - #544
Merged
Conversation
Contributor
|
Can you undo the changes to pubspec? |
Contributor
Contributor
|
It has been a while, are you going to be at technicie next week? Maybe explain the changes to me again, and then I can maybe explain how to make tests. (The logic behind the event message is quite complicated, a test might be a good idea in general) |
… cancellation-status
JAicewizard
previously approved these changes
Nov 19, 2025
rodepanda7
dismissed
JAicewizard’s stale review
November 19, 2025 19:16
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #398 .
Summary
There was a small bug in the logic of displaying the correct registration info
If you cancel your registration, you won't be registered for the event anymore. I changed an
orto anand. If we keep the 'or', the following message will be displayed if you cancelled your registration after the deadline, instead of the message we would like to display: 'Registration is not possible anymore. 'I also added the field
registrationStatusto Event, so we can display the same message as the websiteHow to test
mooi test event