Skip to content

Conversation

@cka121
Copy link
Contributor

@cka121 cka121 commented Dec 8, 2025

This PR adds unit tests for resolving reference for security scheme object in AsyncAPI 3 #OSS-370

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@cka121 cka121 added AsyncAPI 3.x tests tag for anything test related labels Dec 8, 2025
Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The components test looks fine but from what I'm seeing in AsyncAPI 3.0 Security Scheme can also be under security in Operation, Operation Trait and Server, so I think we should add tests for these as well.

@cka121 cka121 requested a review from glowcloud December 11, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AsyncAPI 3.x tests tag for anything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants