DOC-821 Rejection and Return reasons for Merchant payment methods #341
+108
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for incomparable-tiramisu-91a96a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
max-koro
requested changes
Jul 22, 2025
There was a problem hiding this comment.
This looks fantastic. Really thorough work!
Just a couple of small polish items:
- I noticed we use both "rejected" and "declined" - should we pick one and stick with it?
- Quick style thing: could we swap
reach out toforcontact? Reads a bit smoother - Can we make instances of
The transaction was refused by Swan for internal reasons.more descriptive to minimize Support tickets? e.g.Swan declined the transaction due to internal risk management or compliance requirements.
Comment on lines
+163
to
+166
| | `SoftDeclineSwanTechnicalErrorOccurred` | There was a technical error preventing the processing of this payment. | | ||
| | `SoftDeclineTransactionAmountIncorrect` | The transaction amount does not match the expected or authorized amount. | | ||
| | `SwanRefused` | The transaction was refused by Swan for internal reasons. | | ||
| | `SwanTechnicalErrorOccurred` | There was a technical error preventing the processing of this payment. | |
There was a problem hiding this comment.
What is the difference between SoftDeclineSwanTechnicalErrorOccurred and SwanTechnicalErrorOccurred?
| | `SoftDecline3dsExpiration` | The 3D Secure authentication session expired before completion. | | ||
| | `SoftDecline3dsFailure` | The 3D Secure authentication failed. | | ||
| | `SoftDecline3dsNotSupported` | The card does not support 3D Secure authentication. | | ||
| | `SoftDecline3dsRequired` | The transaction requires 3D Secure authentication, but it was not completed. | |
There was a problem hiding this comment.
Suggested change
| | `SoftDecline3dsRequired` | The transaction requires 3D Secure authentication, but it was not completed. | | |
| | `SoftDecline3dsRequired` | 3D Secure authentication was required but not completed. | |
| | `SoftDeclineCardExpired` | The card used is no longer valid because it has expired. | | ||
| | `SoftDeclineCardNotActivated` | The card has not been activated yet. The card holder should reach out to their card issuer for more information. | | ||
| | `SoftDeclineCardNotSupported` | The card is not supported for this type of transaction. The card holder should reach out to their card issuer for more information. | | ||
| | `SoftDeclineCvcCheckFailed` | The CVC security check did not succeed. | |
There was a problem hiding this comment.
Suggested change
| | `SoftDeclineCvcCheckFailed` | The CVC security check did not succeed. | | |
| | `SoftDeclineCvcCheckFailed` | The card security code (CVC) verification failed. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.