-
Notifications
You must be signed in to change notification settings - Fork 10
Doc 1456/wip onboarding v2 preview complete list of changes #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc 1456/wip onboarding v2 preview complete list of changes #502
Conversation
✅ Deploy Preview for incomparable-tiramisu-91a96a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
racene-swan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edits needed to align with docs for consistency. No major red flags so I'll approve so you can push go once the edits are done. Nice work :)
| | `vatNumber` | `company.vatNumber` | | ||
| | - | `company.websites` <sup>(new)</sup> | | ||
|
|
||
| ### Representatives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update these headings so they're consistent with the docs. e.g. Legal representative information
| |---|---| | ||
| | `companyInfoRegistryData` | Project access token | | ||
|
|
||
| The query requires a `registrationNumber` and `residencyAddressCountry`. Currently available for companies registered in **France** (`FRA`) only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the "only in france" message up as this is quite important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they're not in France, its still BAU?
| } | ||
| ``` | ||
|
|
||
| :::caution Behavior change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved up as it's pretty important.
| Field requirements and validations are being finalized. This section will be updated before release. | ||
| ::: | ||
|
|
||
| The following pages provide complete field mappings from the current API to the new API: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes so we use current and new here - so should update the v1/v2 references for consistency.
Co-authored-by: racene-swan <[email protected]>
No description provided.