Skip to content

Make located more general #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 24, 2025
Merged

Make located more general #2597

merged 8 commits into from
Oct 24, 2025

Conversation

@oliverpauffley
Copy link
Collaborator

Sorry dropped the last PR since it was easier just to start over.

LV -> Loc

lvVar -> locVal

@github-actions github-actions bot mentioned this pull request Oct 19, 2025
Merged
xsebek
xsebek approved these changes Oct 19, 2025
View reviewed changes
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this even seems to read better regardless of the change to use it for other types.

I have just two small nitpicks, maybe check your Fourmolu version. 😉

byorgey
byorgey reviewed Oct 19, 2025
View reviewed changes
@oliverpauffley oliverpauffley added the merge me Trigger the merge process of the Pull request. label Oct 24, 2025
@mergify mergify bot added the queued label Oct 24, 2025
mergify bot added a commit that referenced this pull request Oct 24, 2025
@mergify
Merge of #2597
b1bd67d
@mergify mergify bot mentioned this pull request Oct 24, 2025
Closed
28 tasks
@mergify mergify bot merged commit 1f5eb9d into main Oct 24, 2025
13 checks passed
@mergify mergify bot deleted the make-located-more-general branch October 24, 2025 11:32
@mergify mergify bot removed the queued label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@byorgey byorgey byorgey left review comments

@xsebek xsebek xsebek approved these changes

Assignees

No one assigned

Labels

merge me Trigger the merge process of the Pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oliverpauffley @byorgey @xsebek