Open
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
jungleraptor
approved these changes
Dec 5, 2022
Contributor
jungleraptor
left a comment
There was a problem hiding this comment.
Hmm, seems like this is unrelated to the issue I was talking about: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates.
Contributor
|
@isaactorz @krisukox Is this still needed? |
Contributor
I think but I might not be remembering correctly: this would be necessary in order to bump nanopb in cmake. But we ended up not bumping because it also required a cmake update (which would have broken compat with one of our yocto sdks). I think we might leave this one open since we will soon be able to break compat since we're about to be doing the builds in bazel, and are unblocked from updating nanopb on the cmake side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








This option is needed to use the newest nanopb with protoc older than 3.6.0.
Tested here: https://github.com/swift-nav/starling/pull/7239