Skip to content
This repository was archived by the owner on Apr 13, 2021. It is now read-only.

Conversation

@kovach
Copy link
Contributor

@kovach kovach commented Jul 21, 2015

No description provided.

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libswiftnav%20Pull%20Requests/276/
Test PASSed.

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libswiftnav%20Pull%20Requests/279/
Test PASSed.

@kovach
Copy link
Contributor Author

kovach commented Jul 23, 2015

cc @fnoble @henryhallam

@fnoble
Copy link
Contributor

fnoble commented Jul 31, 2015

I think this causes unnecessary coupling between libswiftnav and SBP. We made an effort to move all SBP related stuff out of libswiftnav. Lets chat tomorrow about moving this to sbp_utils.c in piksi_firmware.

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libswiftnav%20Pull%20Requests/291/
Test PASSed.

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libswiftnav%20Pull%20Requests/295/
Test PASSed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not bool?

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libswiftnav%20Pull%20Requests/347/
Test PASSed.

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libswiftnav%20Pull%20Requests/349/
Test PASSed.

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libswiftnav%20Pull%20Requests/350/
Test PASSed.

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libswiftnav%20Pull%20Requests/351/
Test PASSed.

@ljbade
Copy link
Contributor

ljbade commented Jan 6, 2016

@kovach What is needed to get this merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants