I25 viterbi test #289
I25 viterbi test #289
Conversation
|
Please don't merge, comments provided over e-mail... |
|
@rge-exafore Any particular reason for providing comments via email then in a reply here? Generally it is better for everyone else looking at a PR for discussions to be kept on here. |
|
Sorry, @ljbade ... No special reason. I did that as I used to in previous life and then decided not to copy here. Now doing that: Hi Dmitri, I have comments. Please follow the workflow requirements and do the following: |
Notably, adds a test case for the make_propagated_sdiffs function with some synthetic data taken from Kleeman's SITL runner. Checks only to see that the produced outputs are non-zero. /cc @akleeman @benjamin0 @fnoble
Convolutional encoder is python program that takes any input file to encode it into output symbol stream.
|
@ljbade could you please take a look at the coverage/coveralls check. |
|
@dt-exafore I'm looking at it, but something if off with coveralls, it's not finding the source code: https://coveralls.io/builds/4812374/source?filename=src%2Frtcm3.c |
|
Hmm newer builds seem OK. Somehow we need to restart the coveralls job. |
|
@ljbade I've just noticed that the pull request contains 6 changed files while I added just one v27_enc.py |
|
It looks like you've also included a commit from @mookerji, was that unintentional? https://github.com/swift-nav/libswiftnav/pull/289/commits |
|
@JoshuaGross probably it happened after rebasing when I consolidated several commits to one. |
|
@dt-exafore ah if you force push a corrected branch, it should also re-run the coveralls and fix the problem where it was missing the source line numbers in the coveralls report. |
|
@ljbade @JoshuaGross I corrected my pull request. Now it contains only my file. However coveralls check still fails. |
|
Trying to figure out why this caused coverage to drop. @fnoble any ideas? Another question: why is this file in |
|
@JoshuaGross Well, we thought that it's good place since it's related to test data for Viterbi decoder. But, I'll move it to, say, tests/scripts. Is this ok? |
|
Hmm coverage has increased! I'd say this is ready to merge, if @JoshuaGross Is happy with the location of the file now. |
5 participants
Convolutional encoder for Viterbi decoder sanity check.
https://github.com/swift-nav/exafore_planning/issues/25