-
Notifications
You must be signed in to change notification settings - Fork 125
Add head
property to FileDownloadDelegate
's Progress
/Response
struct
#811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lukasa
merged 10 commits into
swift-server:main
from
gregcotten:download-response-add-head
Feb 18, 2025
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
23682ac
add `responseHead` to `FileDownloadDelegate.Progress`
gregcotten 6edf1e7
rename `responseHead` to `head`
gregcotten 82e74b9
init `head` with bogus data
gregcotten 7433b55
add `FileDownloadDelegate.Response` `head` to existing tests
gregcotten 601b2e4
fix XCTAssertEqual order for cohesion
gregcotten a73edf5
FileDownloadDelegate.Progress -> Response
gregcotten 32751ce
project `_head` optional via `head`
gregcotten 16a67ba
use assert for _head nil check, use self
gregcotten 484f55e
format error
gregcotten 448097a
Merge branch 'main' into download-response-add-head
gregcotten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.