Skip to content

Update to librdkafka 2.8.0 #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

mimischi
Copy link
Member

@mimischi mimischi commented Feb 20, 2025

Updates librdkafka to the latest release 2.8.0.

Motivation:

The librdkafka version shipped by this client has gotten fairly old, and there's been a few releases with bug fixes.

Modifications:

A recent commit [1] added a function call that is not available in BoringSSL. This requires us moving away from BoringSSL again.

[1] https://github.com/confluentinc/librdkafka/blame/93877617709eb071a0f4ec7038c54e2764abefc9/src/rdkafka_ssl.c#L1533

Result:

  • Updated librdkafka to 2.8.0.
  • Removed BoringSSL from project (introduced in Ship with BoringSSL #135)
  • libssl-dev now needs to be available during build time again.

Closes #186

Updates `librdkafka` to the latest release 2.8.0. A recent commit* added
a function call that is not available in BoringSSL. This requires us
moving away from BoringSSL again. `libssl-dev` now needs to be available
during build time again.

* https://github.com/confluentinc/librdkafka/blame/93877617709eb071a0f4ec7038c54e2764abefc9/src/rdkafka_ssl.c#L1533

Closes swift-server#186
@mimischi mimischi requested a review from FranzBusch February 20, 2025 11:56
@mimischi mimischi added the 🆕 semver/minor Adds new public API. label Feb 24, 2025
@mimischi mimischi merged commit afad9b2 into swift-server:main Feb 24, 2025
21 of 22 checks passed
@mimischi mimischi deleted the update-librdkafka-280 branch February 24, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants