[lldb] add syntax highlighting infrastructure to Swift plugin #10852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael137
reviewed
Jun 17, 2025
charles-zablit
force-pushed
the
charles-zablit/lldb/add-formatting-swift-plugin
branch
from
0ac3111 to
6909a5f
Compare
|
@swift-ci please test |
| @@ -0,0 +1,8 @@ | |||
| include "../../../../include/lldb/Core/PropertiesBase.td" | |||
|
|
|||
| let Definition = "language_swift" in { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
FWIW, I think keeping it consistent with all the other plugin setting names seems like the right thing to do
There was a problem hiding this comment.
Okay maybe I misunderstood where this string shows up. ToT lldb calls the setting:
'plugin.cplusplus' variables:
'plugin.cplusplus.display' variables:
function-name-format -- C++ specific frame format string to use when displaying stack frame
information for threads.
I really only care about the user-visible name, and I thought this was the category name, but apparently it isn't.
I'm okay with this patch if it results in a
plugin.swift.display.function-name-format variable.
adrian-prantl
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the infrastructure needed to implement function name syntax highlighting in LLDB Swift backtraces.
Motivation
In this patch, @Michael137 implemented name highlighting for methods in the C++ plugin of LLDB. This results in better readability when reading backtraces of functions with long scopes.
Implementation details
This patch only adds the infrastructure/boilerplate needed to implement the feature. The rest of the modifications will be added in #10710.