[6.2 🍒][clang] Fix missing target info specifier on Global Variable linkage computation #11007
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…computation A previous change (swiftlang#10555) added support for querying 'isWeakImported' to be parameterized on the enclosing target version to match 'CheckAvailability' and 'getAvailability'. We missed passing in this parameter in the Clang module code-gen when querying linkage for a global variable. This change adds the missing parameter and removes the default parameter from the query in order to avoid this kind of bug in the future. Resolves rdar://154677999
|
@swift-ci test |
|
@swift-ci test Windows platform |
cyndyishida
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #11006
Explanation: A previous change ([clang] Allow parameterized
isWeakImportbased on an enclosing platform version #10555) added support for querying 'isWeakImported' to be parameterized on the enclosing target version to match 'CheckAvailability' and 'getAvailability'. We missed passing in this parameter in the Clang module code-gen when querying linkage for a global variable. This change adds the missing parameter and removes the default parameter from the query in order to avoid this kind of bug in the future.Scope: Swift Builds using Explicitly-Built modules which specify a deployment target which is older than the SDK default and which depend on Clang modules with global values whose introduction availability version is higher than the compilation's deployment target.
Risk: Low. This change corrects the arguments specified to the global value linkage computation to match those of the compilation's codeine target triple, instead of relying on unspecified defaults.
Testing: Test added to the Swift automated test suite in [6.2 🍒][Test Only] Add a test for correctly querying Clang global variable linkage when using
-clang-targetswift#83076.Reviewed By: @cachemeifyoucan
Problem: rdar://154677999
Original PR: [clang] Fix missing target info specifier on Global Variable linkage computation #11006