[lldb] fix cropped demangled names in Swift backtraces #11068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2025
charles-zablit
changed the title
charles-zablit
added a commit
to llvm/llvm-project
that referenced
this pull request
Aug 5, 2025
…#150999) This patch adds 2 new attributes to `DemangledNameInfo`: `TemplateRange` and `NameQualifiersRange`. It also introduces the `function.name-qualifiers` entity formatter which allows tracking qualifiers between the name of a function and its arguments/template. This will be used downstream in Swift but may have applications in C++: swiftlang#11068.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 5, 2025
…ledNameInfo (#150999) This patch adds 2 new attributes to `DemangledNameInfo`: `TemplateRange` and `NameQualifiersRange`. It also introduces the `function.name-qualifiers` entity formatter which allows tracking qualifiers between the name of a function and its arguments/template. This will be used downstream in Swift but may have applications in C++: swiftlang/llvm-project#11068.
charles-zablit
added a commit
to charles-zablit/llvm-project
that referenced
this pull request
Aug 5, 2025
…llvm#150999) This patch adds 2 new attributes to `DemangledNameInfo`: `TemplateRange` and `NameQualifiersRange`. It also introduces the `function.name-qualifiers` entity formatter which allows tracking qualifiers between the name of a function and its arguments/template. This will be used downstream in Swift but may have applications in C++: swiftlang#11068.
charles-zablit
force-pushed
the
charles-zablit/lldb/fix-cropped-swift-closures-in-backtraces
branch
2 times, most recently
from
97d1880 to
fc8389e
Compare
krishna2803
pushed a commit
to krishna2803/llvm-project
that referenced
this pull request
Aug 12, 2025
…llvm#150999) This patch adds 2 new attributes to `DemangledNameInfo`: `TemplateRange` and `NameQualifiersRange`. It also introduces the `function.name-qualifiers` entity formatter which allows tracking qualifiers between the name of a function and its arguments/template. This will be used downstream in Swift but may have applications in C++: swiftlang#11068.
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Aug 15, 2025
…llvm#150999) This patch adds 2 new attributes to `DemangledNameInfo`: `TemplateRange` and `NameQualifiersRange`. It also introduces the `function.name-qualifiers` entity formatter which allows tracking qualifiers between the name of a function and its arguments/template. This will be used downstream in Swift but may have applications in C++: swiftlang#11068.
|
Can you rebase this on |
| size_t generic_end = generic_start + 1; | ||
|
|
||
| while (generic_end < demangled_name.size() && generic_depth > 0) { | ||
| if (demangled_name[generic_end] == '<') { |
There was a problem hiding this comment.
LLVM coding style prefers no {} in single-statements:
if (demangled_name[generic_end] == '<')
generic_depth++;
else if ...
charles-zablit
force-pushed
the
charles-zablit/lldb/fix-cropped-swift-closures-in-backtraces
branch
from
fc8389e to
d61aa2f
Compare
charles-zablit
changed the base branch from
swift/release/6.2
to
swift/release/6.2.1
adrian-prantl
approved these changes
Aug 20, 2025
|
|
||
| if (!info.hasPrefix()) | ||
| return llvm::createStringError( | ||
| "DemangledInfo for '%s does not have a name qualifiers range.", |
There was a problem hiding this comment.
"DemangledInfo for '%s' does not have a name qualifiers range.",
also, is there a way to phrase this without referencing DemangledInfo (in case users see this?)
There was a problem hiding this comment.
Replaced it with: "The demangled name for '%s does not have a name qualifiers range.", and fixed the 3 other occurrences as well.
charles-zablit
force-pushed
the
charles-zablit/lldb/fix-cropped-swift-closures-in-backtraces
branch
from
d61aa2f to
f654f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
TestSwiftAsyncHiddenFrames.pywhich had been failing since #10710 was merged.This PR introduces a new entity formatting attribute:
function.name-qualifiers. It's a catch all for any characters between the function's name and its arguments/template arguments. For instance, for the closure below,in C.runis the name qualifier.This PR depends on: