[lldb] Add Swift exception breakpoint frame recognizer #11097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
A follow up to this is to implement |
|
@swift-ci test macOS |
9 similar comments
|
@swift-ci test macOS |
|
@swift-ci test macOS |
|
@swift-ci test macOS |
|
@swift-ci test macOS |
|
@swift-ci test macOS |
|
@swift-ci test macOS |
|
@swift-ci test macOS |
|
@swift-ci test macOS |
|
@swift-ci test macOS |
|
@swift-ci test |
|
Depends on llvm#152201 |
kastiglione
force-pushed
the
dl/lldb-Add-Swift-exception-breakpoint-frame-recognizer
branch
from
7a6b847 to
873a804
Compare
|
@swift-ci test |
kastiglione
force-pushed
the
dl/lldb-Add-Swift-exception-breakpoint-frame-recognizer
branch
from
873a804 to
c32f0e8
Compare
|
@swift-ci test |
|
@swift-ci test windows |
kastiglione
force-pushed
the
dl/lldb-Add-Swift-exception-breakpoint-frame-recognizer
branch
from
c32f0e8 to
24a758a
Compare
|
@swift-ci test |
Fixes a bug that surfaces in frame recognizers. Details about the bug: A new frame recognizer is configured to match a specific symbol (`swift_willThrow`). This is an `extern "C"` symbol defined in a C++ source file. When Swift is built with debug info, the function `ParseFunctionFromDWARF` will use the debug info to construct a function name that looks like a C++ declaration (`::swift_willThrow(void *, SwiftError**)`). The `Mangled` instance will have this string as its `m_demangled` field, and have _no_ string for its `m_mangled` field. The result is the frame recognizer would not match the symbol to the name (`swift_willThrow` != `::swift_willThrow(void *, SwiftError**)`. By changing `ParseFunctionFromDWARF` to assign both a demangled name and a mangled, frame recognizers can successfully match symbols in this configuration. (cherry picked from commit 2959051)
kastiglione
force-pushed
the
dl/lldb-Add-Swift-exception-breakpoint-frame-recognizer
branch
from
24a758a to
d97c0f6
Compare
|
@swift-ci test |
|
rebased to stable/21.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a frame recognizer for Swift breakpoint exceptions (
break set -E swift).This initial version does the following:
Selecting the frame where the throw occurs allows more direct inspection of the context that is throwing, and avoids displaying Swift's internal callback hook, which isa frame with no source and no variables – only disassembly.
rdar://156452605