[lldb] Fallback to expression eval when Dump of variable fails in dwim-print (#151374) #11099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-print (llvm#151374) Previously, when dwim-print finds a frame variables, it returns immediately after calling `Dump`, even if `Dump` returns an error. This is most likely to happen when evaluating an object description, ie `po`. This changes dwim-print to continue on to expression evaluation when `Dump`ing a variable returns an error . This is to allow for diagnostics that match `expression`. (cherry picked from commit f23c10f)
|
@swift-ci test |
|
@swift-ci test windows |
|
This will likely be aborted in favor of llvm#152417 |
|
reverted upstream, closing this cherry pick |
kastiglione
deleted the
dl/lldb-Fallback-to-expression-eval-when-Dump-of-variable-fails-in-dwim-print-151374
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when dwim-print finds a frame variables, it returns immediately after
calling
Dump, even ifDumpreturns an error. This is most likely to happen whenevaluating an object description, ie
po.This changes dwim-print to continue on to expression evaluation when
Dumping avariable returns an error . This is to allow for diagnostics that match
expression.(cherry picked from commit f23c10f)
rdar://134291640