[clang][Dependency Scanning] Testing Config Macro Canonicalization with CAS #11454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiongsiwu
requested review from
Bigcheese,
cachemeifyoucan,
jansvoboda11 and
benlangmuir
|
@cachemeifyoucan @jansvoboda11 Do you think I should keep this test now that llvm#159620 landed with a test? I think it is worth keeping since this tests the CAS variants directly. |
jansvoboda11
approved these changes
Sep 19, 2025
cachemeifyoucan
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test accompanying llvm#159620. Without llvm#159620, this test fails.
Specifically, without the fix, when CAS is on, there are three variants of A. With the fix, there should be only two variants.
Part of work for rdar://136303612