Skip to content

Conversation

ahatanaka
Copy link

This implements Sema support for the flag added in 1afc96b.

rdar://157602517

Unified Feature Flags

This implements Sema support for the flag added in
1afc96b.

rdar://157602517
@ahatanaka
Copy link
Author

@swift-ci test llvm

Copy link

@tshortli tshortli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add some basic Sema tests for Obj-C declarations, just to help ensure the basic functionality does not regress in a language specific way?


#ifdef USE_DOMAIN
void test8(void) {
// FIXME: Use of 'func21()' should not be diagnosed because feature5 is always available.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This FIXME should be removed

Also test always-enabled features.
@ahatanaka
Copy link
Author

@swift-ci test llvm

@ahatanaka
Copy link
Author

There was another place where unguarded uses of declarations were diagnosed, which I didn't notice.

@ahatanaka
Copy link
Author

@swift-ci test llvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants