Cherrypick 3 commits to Stable/21.x #12044
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions (llvm#145862) The character buffer passed to a "%.*s" specifier may be safely bound if the precision is properly specified, even if the buffer does not guarantee null-termination. For example, ``` void f(std::span<char> span) { printf("%.*s", (int)span.size(), span.data()); // "span.data()" does not guarantee null-termination but is safely bound by "span.size()", so this call is safe } ``` rdar://154072130 (cherry picked from commit e10b182) Conflicts: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-libc-functions.cpp
…ction names (llvm#151270) This commit fixes the false positive that C++ class methods with libc function names would be false warned about. For example, ``` struct T {void strcpy() const;}; void test(const T& t) { str.strcpy(); // no warn } ``` rdar://156264388 (cherry picked from commit 0abf497) Conflicts: clang/lib/Analysis/UnsafeBufferUsage.cpp
…vm#170496) `clang::analyze_format_string::ParsePrintfString` also returns `true` when we get an invalid or erroneous format string, so `UnsafeArg` will not be set, but `hasUnsafeFormatOrSArg`'s caller assumes `UnsafeArg` will be valid when it returns true, which leads to crash. Closes llvm#169629 (cherry picked from commit b5dd6cc) Conflicts: clang/docs/ReleaseNotes.rst clang/lib/Analysis/UnsafeBufferUsage.cpp
Author
|
@swift-ci test |
Author
|
@swift-ci test llvm |
Author
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.