If sourcekitd or clangd don’t respond to a request for 5 minutes, terminate them and use crash recovery to restore behavior #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
terminate-unresponsive-clangd-sourcekitd
branch
from
562bf80 to
21e3bc3
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
…minate them and use crash recovery to restore behavior This should be a last stop-gap measure in case sourcekitd or clangd get stuck, don’t respond to any requests anymore and don’t honor cancellation either. In that case we can restore SourceKit-LSP behavior by killing them and using the crash recovery logic to restore functionality. rdar://149492159
ahoppen
force-pushed
the
terminate-unresponsive-clangd-sourcekitd
branch
from
21e3bc3 to
14cfd50
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
added a commit
to bnbarham/sourcekit-lsp
that referenced
this pull request
May 12, 2025
…sponsive-clangd-sourcekitd" This change is too risky for 6.2 at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a last stop-gap measure in case sourcekitd or clangd get stuck, don’t respond to any requests anymore and don’t honor cancellation either. In that case we can restore SourceKit-LSP behavior by killing them and using the crash recovery logic to restore functionality.
rdar://149492159