[SwiftLanguageService] Adopt to throwing refactoring actions #2251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
approved these changes
Aug 23, 2025
Sources/SwiftLanguageService/CodeActions/SyntaxRefactoringCodeActionProvider.swift
Outdated
Show resolved
Hide resolved
`EditRefactoringProvider.textRefactor` and `EditRefactoringProvider.refactor` requirements are now throwing and produce a non-optional type.
xedin
force-pushed
the
throwing-refactoring-actions
branch
from
acaebe3 to
28ec028
Compare
|
swiftlang/swift-syntax#3142 |
|
swiftlang/swift-syntax#3142 |
bnbarham
reviewed
Aug 25, 2025
| } | ||
|
|
||
| let sourceEdits = Self.textRefactor(syntax: node) | ||
| guard let sourceEdits = try? Self.textRefactor(syntax: node) else { |
There was a problem hiding this comment.
@ahoppen I assume this runs on cursor movement generally and thus logging the reasons here would be too spammy?
bnbarham
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is failed with swift-syntax.
EditRefactoringProvider.textRefactorandEditRefactoringProvider.refactorrequirements are now throwing and produce a non-optional type.