Drop support for building with Swift 6.1 #2300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
Swift 6.2 has been released, so we no longer need to support building and testing SourceKit-LSP using Swift 6.1
ahoppen
commented
Sep 20, 2025
| #if compiler(>=6.3) | ||
| #warning("We have had a one year transition period to the pull based build server. Consider removing this build server") | ||
| #if compiler(>=6.5) | ||
| #warning("We have had a two year transition period to the pull based build server. Consider removing this build server") |
There was a problem hiding this comment.
https://github.com/SolaWing/xcode-build-server is the only BSP server that I am aware of, which uses the legacy push-based model. While it has transitioned to the pull-based model (SolaWing/xcode-build-server@a030fea), it has not released a version that includes this change. Add another year of transition period to allow all BSP servers to transition.
|
@swift-ci Please test |
bnbarham
approved these changes
Sep 21, 2025
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 6.2 has been released, so we no longer need to support building and testing SourceKit-LSP using Swift 6.1