Pseudo-namespace runner struct in test entrypoints #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
aciidgh,
jakepetroules,
mhrawdon and
neonichu
as code owners
Collaborator
Author
|
@swift-ci test |
jakepetroules
approved these changes
Dec 9, 2025
| @available(macOS 10.15, iOS 11, watchOS 4, tvOS 11, visionOS 1, *) | ||
| @available(*, deprecated, message: "Not actually deprecated. Marked as deprecated to allow inclusion of deprecated tests (which test deprecated functionality) without warnings") | ||
| struct Runner { | ||
| struct __SwiftPMGeneratedTestRunner { |
Collaborator
There was a problem hiding this comment.
nit: maybe just "__SwiftGeneratedTestRunner"?
Collaborator
Author
There was a problem hiding this comment.
For now I'm mirroring the other types we generate for the sake of consistency
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it may collide with user code.
Closes swiftlang/swift-package-manager#9467