Fix PIF API which dropped resourceRule field #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
aciidgh,
jakepetroules,
mhrawdon and
neonichu
as code owners
Collaborator
Author
|
@swift-ci test |
Collaborator
Author
|
@swift-ci test macOS |
1 similar comment
Collaborator
Author
|
@swift-ci test macOS |
neonichu
approved these changes
Dec 9, 2025
jakepetroules
approved these changes
Dec 9, 2025
| public var platformFilters: Set<PlatformFilter> = [] | ||
| public var codeSignOnCopy: Bool = false | ||
| public var removeHeadersOnCopy: Bool = false | ||
| public var resourceRule: ResourceRule? = nil |
Collaborator
There was a problem hiding this comment.
I think all of the default values for instance variables should be removed; they tend to hide this problem. Let the constructors handle the default parameters.
owenv
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Dec 10, 2025
…esource bundle (#9486) This is required in order to ensure that package resource accessors are correctly generated for the testable variants Closes #9459 Depends on swiftlang/swift-build#967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.