Skip to content

Add case within XML Node's name setter for DTDKind (#5230) #5232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pranavkarthik10
Copy link

Fixes #5230 by force setting the name for XMLNodes when they're XMLDTDs as the regular _CFXMLNodeSetName function doesn't account for them with future versions of libxml2

Force set the name for XMLNodes when they're XMLDTDs as the regular _CFXMLNodeSetName function doesn't account for them anymore
@parkera
Copy link
Contributor

parkera commented Jul 2, 2025

@swift-ci test

@parkera
Copy link
Contributor

parkera commented Jul 2, 2025

Looks reasonable - can we add a unit test too?

@parkera parkera self-requested a review July 2, 2025 21:43
@pranavkarthik10
Copy link
Author

pranavkarthik10 commented Jul 2, 2025

There's this existing test that checks for this exact functionality:

This issue only gets highlighted with the more recent libxml2 versions though, which the CI probably isn't on yet. Let me know if there's any other way to test this or other tests to add.

@parkera
Copy link
Contributor

parkera commented Jul 2, 2025

Oh ok, that's fine then. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XMLDTD's name setter doesn't work with libxml2 2.13.0 or later
2 participants