[6.2] Don't remove leading and trailing parentheses for closure types in type signature disambiguation #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
d-ronnqvist
commented
Jun 18, 2025
d-ronnqvist
commented
- Explanation: This fixes an issue where DocC would remove leading and trailing parentheses from certain closure parameter types in the suggested disambiguation.
- Scope: Incorrect suggested disambiguations in some cases.
- Issue: rdar://151311221
- Risk: Low.
- Testing: Added tests that verify the suggested disambiguations for more and additional test validation that the suggested disambiguation work. Manually verified with the project where this issue was originally reported. Existing automated tests pass.
- Reviewer: @patshaughnessy
- Original PR: Don't remove leading and trailing parentheses for closure types in type signature disambiguation #1231
…pe signature disambiguation (swiftlang#1231) * Fix issue where suggested link disambiguation removed leading and trailing parentheses for some closure types rdar://151311221 * Minor unrelated correction of whitespace in symbol declaration test data * Include more information in test failure messages about unknown disambiguation
|
@swift-ci please test |
franklinsch
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.