Skip to content

Static Linux SDK: change cmake build directory #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

xavgru12
Copy link
Contributor

@xavgru12 xavgru12 commented Apr 5, 2025

Resolves #460

@xavgru12 xavgru12 requested a review from shahmishal as a code owner April 5, 2025 15:44
@xavgru12
Copy link
Contributor Author

@al45tair

I have another pull request right here. Let me know if this is okay as well!

@xavgru12 xavgru12 changed the title change cmake build directory Static Linux SDK: change cmake build directory Jul 16, 2025
Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to build in the build_dir rather than the source_dir.

@xavgru12
Copy link
Contributor Author

xavgru12 commented Jul 21, 2025

Do we need more approvals here?
Can we run the CI?

@al45tair
Copy link
Contributor

The CI is supposed to trigger automatically for this repo. @shahmishal, do we need to poke something here?

@xavgru12 xavgru12 marked this pull request as draft July 22, 2025 15:14
@xavgru12 xavgru12 marked this pull request as ready for review July 22, 2025 15:15
@xavgru12
Copy link
Contributor Author

I tried to trigger it with a force push, but did not work

@shahmishal shahmishal enabled auto-merge (squash) July 22, 2025 20:35
@shahmishal shahmishal merged commit 3bf68fb into swiftlang:main Jul 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static Linux SDK: build errors at cmake build
3 participants