Update Strings.md to include CMake include #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/EmbeddedSwift/Documentation.docc/UsingEmbeddedSwift/Strings.md
Outdated
Show resolved
Hide resolved
| -Wl,--no-whole-archive | ||
| ) | ||
| # message(" ----------::: ${additional_lib_path} :::---------- ") |
There was a problem hiding this comment.
Should this line be included?
There was a problem hiding this comment.
Do you mean the message? I'm fine with removing it. Alternatively, I can add a mention about its roll in trouble shooting if people unfamiliar with CMake might find that helpful.
There was a problem hiding this comment.
Add the extra comment, but still willing to remove it if it's distracting.
There was a problem hiding this comment.
Ah okay so it's just a debug message. I wasn't sure if it was meant to be part of the official example here. It could be noted separately for debugging if you like.
xtremekforever
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Zephyr instructions!