[SE-0471] Make diagram readable in dark mode #2866
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the diagram embedded in "SE-0471: Improved Custom SerialExecutor isolation checking for Concurrency Runtime" with a version that is readable in dark mode. I did this by exporting the diagram from OmniGraffle with a solid white background. The previous version had a transparent background, which made the black arrows between the boxes invisible in dark mode.
Lishkk
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the diagram embedded in "SE-0471: Improved Custom SerialExecutor isolation checking for Concurrency Runtime" with a version that is readable in dark mode. I did this by exporting the diagram from OmniGraffle with a solid white background. The previous version had a transparent background, which made the black arrows between the boxes invisible in dark mode.
cc @ktoso
For reference, this is how the old diagram looked in dark mode:
Note that the arrows/connections between the boxes are invisible. The new image has a solid white background to prevent this.