formattedAttributedLeadingDotSyntax() test failed #1422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test and other tests testing the dot syntax assume that the left hand side of the comparison is using the same locale as the right side, in which case is `Locale.autoupdatingCurrent`. This further assumes that the state of the host machine remains unchanged throughout the tests. Fix this by specifying the locale of the left and right side so they don't depend on the current locale settings. Addresses 154994643
|
@swift-ci please test |
jmschonfeld
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test and other tests testing the dot syntax assume that the left hand side of the comparison is using the same locale as the right side, in which case is
Locale.autoupdatingCurrent. This further assumes that the state of the host machine remains unchanged throughout the tests.Fix this by specifying the locale of the left and right side so they don't depend on the current locale settings.
Addresses 154994643