Skip to content

Limit the use of concurrent scope in unit tests #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

itingliu
Copy link
Contributor

Many tests for the dot syntax assume that the left hand side of the comparison is using the same locale as the right side, in which case is Locale.autoupdatingCurrent. Previously we put them inside usingCurrentInternationalizationPreferences to ensure that the current locale isn't mutated concurrently while the tests are running. That works but we can also set the locale of both the left and right side to a specific locale so they don't depend on the current status.

Addresses 155437764

Many tests for the dot syntax assume that the left hand side of the comparison is using the same locale as the right side, in which case is `Locale.autoupdatingCurrent`. Previously we put them inside `usingCurrentInternationalizationPreferences` to ensure that the current locale isn't mutated concurrently while the tests are running. That works but we can also set the locale of both the left and right side to a specific locale so they don't depend on the current status.

Addresses 155437764
@itingliu
Copy link
Contributor Author

@swift-ci please test

@itingliu itingliu requested a review from jmschonfeld July 10, 2025 20:12
@itingliu itingliu merged commit 4b0ee0a into swiftlang:main Jul 11, 2025
16 checks passed
@itingliu itingliu deleted the limit-concurrent-scope-tests branch July 11, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants