Prototyping Swift Array Accessor #207
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Jan 15, 2025
| [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] | ||
| } | ||
|
|
||
| let DATA = [ |
There was a problem hiding this comment.
TODO: make it not global and deal with lifetime
ktoso
commented
Jan 15, 2025
| @@ -77,6 +91,15 @@ public class MySwiftClass { | |||
| p("i:\(i)") | |||
| } | |||
|
|
|||
| // TODO: workaround until we expose properties again | |||
There was a problem hiding this comment.
TODO: Seems we didn't yet finish moving to the "thunk way" the properties, gotta do that.
ktoso
commented
Jan 15, 2025
| // ==== ------------------------------------------------------------------------ | ||
| // swap | ||
|
|
||
| public Wrapped swap(int i, int j) { |
There was a problem hiding this comment.
fixme, wrong signature
ktoso
force-pushed
the
wip-swift-array-accessor
branch
2 times, most recently
from
a5b2057 to
2d7fb88
Compare
ktoso
force-pushed
the
wip-swift-array-accessor
branch
from
2d7fb88 to
49d8ffa
Compare
|
This is fully expected to conflict a lot right now; I pulled pieces out from it and had changed around a bit to make incremental progress on value types support for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early prototyping of a type that is able to operate from Java on native Swift arrays without copying them out of Swift land.
The wrapper should be able to be generic and reasonably safe, where lifetime is managed with an arena, and it is typesafe when used with jextract imported types.