[jextract] Misc improvements #223
Merged
+200
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce `Swift2JavaVisitor.typeContext` to handle nested types * Unify `shouldImport(log:)` method using `WithModifiersSyntax & WithAttributesSyntax` * Unify `accessControlModifiers` as an extention to `WithModifiersSyntax` * Don't import `JavaKit` declarations. e.g. `@JavaClass` * Don't import non-public variable decls. * Introduce `DeclSyntaxProtocol.qualifiedNameForDebug` and use it for log messages * Introduce `DeclSyntaxProtocol.signatureString` and use it as the snippet in the exported `.java` files.
ktoso
approved these changes
Apr 15, 2025
| fatalError("unimplemented \(self.kind)") | ||
| } | ||
| } | ||
| } |
DougGregor
approved these changes
Apr 15, 2025
| @@ -26,7 +26,11 @@ final class Swift2JavaVisitor: SyntaxVisitor { | |||
| /// store this along with type names as we import them. | |||
| let targetJavaPackage: String | |||
|
|
|||
| var currentType: ImportedNominalType? = nil | |||
| /// Type context stack associated with the syntax. | |||
| var typeContext: [(syntaxID: Syntax.ID, type: ImportedNominalType)] = [] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift2JavaVisitor.typeContextto handle nested typesshouldImport(log:)method usingWithModifiersSyntax & WithAttributesSyntaxaccessControlModifiersas an extention toWithModifiersSyntaxopendeclarationsJavaKitdeclarations. e.g.@JavaClassDeclSyntaxProtocol.qualifiedNameForDebugand use it for log messagesDeclSyntaxProtocol.signatureStringand use it as the snippet in the exported.javafiles.