[WIP] Allow returning new java objects from JNI downcall #227
+182
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must reinvent how we promote values to global refs etc. Without the promotion we get a null. We need to manage the retains automatically as we return from a downcall in any wrapped java wrapper class etc...
ktoso
commented
May 5, 2025
| @@ -38,6 +39,6 @@ public class JavaObjectHolder { | |||
| } | |||
|
|
|||
| deinit { | |||
| self.forget() | |||
| // self.forget() | |||
There was a problem hiding this comment.
fixme, not real solution ofc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't really a solution but just showcases the issue.
We cannot just return a newly created object without keeping the ref alive as we'll get a null on the java side otherwise.
The solution will be managing refs and checking if we escaped them or not proably...