Skip to content

Conversation

colemancda
Copy link
Contributor

@colemancda colemancda commented Jul 13, 2025

The JNI C header included in the Android NDK is slightly different (as is the case with most C API's Android exposes) from the standard desktop Java counterpart. This PR allows JavaKit to compile on Android with the jni.h provided in the NDK.

Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, I'm happy to accept those changes, but I'd love to get Android CI as we start accepting more Android improvements. Looking forward to chat with the workgroup how quickly we could get that set up.

@ktoso ktoso added the android label Jul 13, 2025
@colemancda colemancda changed the title [JavaKit] Add JNIEnvPointer for Android [JavaKit] Add JNIEnvPointer and JNINativeInterface_ for Android Jul 13, 2025
@ktoso ktoso merged commit a3791cf into swiftlang:main Aug 3, 2025
129 of 140 checks passed
@ktoso
Copy link
Collaborator

ktoso commented Aug 3, 2025

Thanks, sorry to keep you waiting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants