Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup several classes of warnings #8361

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixup several classes of warnings #8361

wants to merge 6 commits into from

Conversation

plemarquand
Copy link
Contributor

@plemarquand plemarquand commented Mar 11, 2025 •
edited
Loading

  • Remove @_implementationOnly in favour of internal import
  • Remove now-redundant Sendable conformances
  • Remove unused variables
  • Fix a few missed unnecessary @retroactive conformances
  • Use swiftlang/swift-llbuild.git instead of apple/swift-llbuild.git

@jakepetroules
Copy link
Contributor

@swift-ci test

@plemarquand plemarquand force-pushed the fix-more-warnings branch 5 times, most recently from 3aa9445 to 9e779b0 Compare March 13, 2025 13:44
@plemarquand
Copy link
Contributor Author

@swift-ci test

@plemarquand
Fixup several classes of warnings
a951bf8 
- Remove `@_implementationOnly` in favour of `internal import`
- Remove now-redundant Sendable conformances
- Remove unused variables
- Fix a few missed unnecessary `@retroactive` conformances
- Use swiftlang/swift-llbuild.git instead of apple/swift-llbuild.git
@plemarquand
Import required modules for Basics
ddd7efa
@plemarquand
Fix abiguous import of TSCclibc
3e58c0c
@plemarquand
Internal import Foundartion in PackageDescription
8cbf78c
@plemarquand
Make foundation imports more consistent
9927188
@plemarquand plemarquand force-pushed the fix-more-warnings branch 2 times, most recently from 56dbf24 to 86313d6 Compare March 14, 2025 13:13
@plemarquand
Copy link
Contributor Author

@swift-ci test

@plemarquand
Copy link
Contributor Author

@swift-ci test windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@bkhouri bkhouri Awaiting requested review from bkhouri bkhouri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plemarquand @jakepetroules