Mark a few PackageCollectionModel types as Sendable
#8635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…V1.SignedCollection Sendable
finestructure
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
MaxDesiatov
approved these changes
May 8, 2025
|
@swift-ci test |
MaxDesiatov
changed the title
PackageCollectionModel types as Sendable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We are using SwiftPM as a dependency to vend signed package collections on the Swift Package Index website.
(There are some more details around why we do this and don't think we have an alternative laid out in this issue.)
After updating to Swift 6, we've had to introduce a
@retroactive @unchecked SendableonSignedCollectionin order to conform it toVapor.Contentand send it in web responses.Modifications:
This change marks the related types as
Sendable.Result:
With this change, we can drop the retroactive unchecked conformance. We've tested this with our project on a fork here:
https://github.com/SwiftPackageIndex/SwiftPackageIndex-Server/actions/runs/14808870777