Tests: Convert RegistryClientTests to Swift Testing

[plemarquand]

Continue the test conversion to Swift Testing

• Tests/PackageRegistryTests/RegistryClientTests.swift

[plemarquand]

@swift-ci test

[bkhouri]

Thanks for converting tests to Swift Testing. It's appreciated getting assistance with these.

I noticed some test are calling testDiagnostics(...), which has a call to XCFail. We should use expectDiagnostics(...) instead to avoid a test using a mix of Swift Test and XCTest calls.

[bkhouri]

suggestion (non-blocking): this do block, and the one before, are very similar and can be converted to a parameterized tests.

[plemarquand]

Done

[bkhouri]

suggestion (non-blocking): In order to be more explicit, the value of the expected passed tools version can be passed in as the test data, instead of using `toolsVersion ?? .current)

[plemarquand]

This exercises that "nil" is interpreted as .current, so was deliberate

[bkhouri]

I understand the test intent, but the test can look cleaner as a parameterized test.

e.g.

@Test(
    arguments: [
        (toolsVersion: ToolsVersion.v5_3, expectedParsedVersion: ToolsVersion.v5_3),
        (toolsVersion: nil, expectedParsedVersion: ToolsVersion.current),
    ]
)
func mytest(toolsVersion: ToolsVersion?, expectedParsedVersion: ToolsVersion) async throws {
    ...
    #expect(parsedToolsVersion == expectedParsedVersion)
}

[plemarquand]

@swift-ci test

[plemarquand]

@swift-ci test windows

[plemarquand]

@swift-ci please test windows

the blocking comment was address.