Test: Skip test on Amazon Linux 2 #8649
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test caused a stack trace on Amazon Linux 2. Skip it for now.
bkhouri
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
| @@ -326,7 +327,12 @@ struct FilePackageSigningEntityStorageTests { | |||
| #expect(packageSigners.signers[davinci]?.origins == [.registry(URL("http://foo.com"))]) | |||
| } | |||
|
|
|||
| @Test | |||
| @Test( | |||
There was a problem hiding this comment.
Could you refactor this into its own trait so it's reusable?
extension Trait where Self == Testing.ConditionTrait {
package static var skipAmazonLinux2: Self {
disabled("Test fails on Amazon Linux 2", {
ProcessInfo.hostOperatingSystem == .linux && (FileManager.default.contents(atPath: "/etc/system-release").map({ String(decoding: $0, as: UTF8.self) == "Amazon Linux release 2 (Karoo)\n" }) ?? false)
})
}
}There was a problem hiding this comment.
I definitely thought of this, but that's not currently possible as adding an import Testing in the _InternalTestSupport target will cause other pipelines to start failing since, in the build-script, swift PM will build itself using Cmake, and then will build the projects using the artifacts that was produced with the Cmake.
There was a problem hiding this comment.
This should be possible once swiftlang/swift#81401 is merged, hopefully.
auto-merge was automatically disabled
May 12, 2025 17:11
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test caused a stack trace on Amazon Linux 2. Skip it for now.