[Syntax] Remove unnecessary special attribute arguments syntax kinds #3028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
attributes-reorg
branch
2 times, most recently
from
1a0f9ee to
76f63cf
Compare
rintaro
changed the title
Some attributes are expressed with the regular 'LabeledExprListSyntax' There's no need for special argument list syntax kind and keywords.
rintaro
force-pushed
the
attributes-reorg
branch
from
76f63cf to
d9d8c5c
Compare
|
swiftlang/swift#80351 |
rintaro
force-pushed
the
attributes-reorg
branch
from
d9d8c5c to
78308fc
Compare
|
swiftlang/swift-format#971 |
|
swiftlang/swift-format#971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many attributes can be expressed with the regular
LabeledExprListSyntax. Custom attribute list syntax kinds and the custom parsing functions doesn't give us much benefit other than someParserDiagnostics. Also those random selection of attribute kinds can be confusing.