Introduce FixIt.Change.replaceText #3030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new case to FixIt.Change to express an unstructured edit, which replaces some range of source text (in a given file) with some other source text. This is needed for some edits that aren't easily mapped to the syntax tree, or when coming from other tools (such as the compiler) that don't express these fixes in terms of syntax in the first place.
|
@swift-ci please test |
|
@swift-ci please test |
|
swiftlang/llvm-project#10369 @swift-ci please test Windows |
ahoppen
reviewed
Mar 28, 2025
Sources/SwiftDiagnostics/FixIt.swift
Outdated
| /// this case provides a fallback for textual replacement that ignores | ||
| /// syntactic structure. After applying a textual replacement, there is no | ||
| /// way to get back to a syntax tree without reparsing. | ||
| case textualReplacement(replacementRange: Range<AbsolutePosition>, sourceFile: SourceFileSyntax, newText: String) |
There was a problem hiding this comment.
To match the other cases, this should start with replace as well. I would suggest replaceText.
Suggested change
| case textualReplacement(replacementRange: Range<AbsolutePosition>, sourceFile: SourceFileSyntax, newText: String) | |
| case replaceText(range: Range<AbsolutePosition>, with: String, in: SourceFileSyntax) |
Rename according to the discussion. Additionally, only require a Syntax node (not a SourceFileSyntax) as the place we're rewriting from.
|
@swift-ci please test |
|
@swift-ci please test Windows |
DougGregor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new case to FixIt.Change to express an unstructured edit, which replaces some range of source text (in a given file) with some other source text. This is needed for some edits that aren't easily mapped to the syntax tree, or when coming from other tools (such as the compiler) that don't express these fixes in terms of syntax in the first place.