[SwiftParser] Update whitespace rule between attribute name and '(' #3146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham and
hamishknight
as code owners
rintaro
force-pushed
the
parse-attr-lparen-space-rdar147785544
branch
from
0ab9384 to
08704ad
Compare
|
swiftlang/swift#84128 |
hamishknight
approved these changes
Sep 10, 2025
In Swift 6 and later, whitespace is no longer permitted between an
attribute name and the opening parenthesis. Update the parser so that in
Swift 6+, a '(' without preceding whitespace is always treated as the
start of the argument list, while a '(' with preceding whitespace is
considered the start of the argument list only when it is unambiguous.
This change makes the following closure be parsed correctly:
```swift
{ @mainactor (arg: Int) in ... }
```
rdar://147785544
rintaro
force-pushed
the
parse-attr-lparen-space-rdar147785544
branch
from
08704ad to
16c4014
Compare
|
swiftlang/swift#84128 |
|
swiftlang/swift#84128 |
1 similar comment
|
swiftlang/swift#84128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift 6 and later, whitespace is no longer permitted between an attribute name and the opening parenthesis. Update the parser so that in Swift 6+, a '(' without preceding whitespace is always treated as the start of the argument list, while a '(' with preceding whitespace is considered the start of the argument list only when it is unambiguous.
This change makes the following closure be parsed correctly:
rdar://147785544