[SwiftWarningControl] Keep track of enabled diagnostic group identifiers #3179
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows platform |
artemcm
force-pushed
the
WarningControl-KeepTrackOfEnabled
branch
from
e52ea22 to
45401fd
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows platform |
artemcm
force-pushed
the
WarningControl-KeepTrackOfEnabled
branch
2 times, most recently
from
3039f19 to
86ac634
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows platform |
ahoppen
reviewed
Nov 7, 2025
| /// Produce a set of diagnostic group identifiers contained in | ||
| /// this tree which have a behavior specifier other than `ignored`. | ||
| @_spi(ExperimentalLanguageFeatures) | ||
| public func getEnabledDiagnosticGroups() -> Set<DiagnosticGroupIdentifier> { |
Member
There was a problem hiding this comment.
Should this just be a computed property? Or rather, why not expose enabledGroups as @_spi(…) public private(set)?
Contributor
Author
There was a problem hiding this comment.
Yeah, that makes sense. Changed to be a @_spi(…) public private(set) property.
And add public API on `WarningControlRegionTree` to query them: `getEnabledDiagnosticGroups`. This is intended to be used by clients (the compiler) to be able to query whether a given diagnostic group has been enabled in a given source file.
artemcm
force-pushed
the
WarningControl-KeepTrackOfEnabled
branch
from
86ac634 to
bc8fd0a
Compare
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
ahoppen
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add public API on
WarningControlRegionTreeto query them:getEnabledDiagnosticGroups. This is intended to be used by clients (the compiler) to be able to query whether a given diagnostic group has been enabled in a given source file.